Re: [PATCH] 2.5: push BKL out of llseek

Robert Love (rml@tech9.net)
30 Jan 2002 08:39:12 -0500


On Wed, 2002-01-30 at 03:00, Trond Myklebust wrote:

>> " " == Alexander Viro <viro@math.psu.edu> writes:
>
> > So I'd prefer to do it in two stages - shift BKL into
> > ->llseek() and then see where it can be dropped/replaced with
> > ->i_sem.
>
> Seconded. There are several filesystems out there for which i_sem does
> nothing to protect inode->i_size.

Then the first patch is the way to go. We know generic_file_llseek is
safe and perhaps a few other of the llseek methods. The remaining can
explicitly grab the bkl on their own, as Al suggested.

Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/