Re: [PATCH] amiga input api drivers III

[Geert Uytterhoeven]

On Thu, 31 Jan 2002, James Simmons wrote:
> Okay. This patch should now work. Give it a try. Remember also the amiga
> joystick and mouse are alredy in the Dave Jones tree waiting to be tested
> :-)
> 
> diff -urN -X /home/jsimmons/dontdiff linux-2.5.2-dj7/drivers/input/keyboard/amikbd.c linux/drivers/input/keyboard/amikbd.c
> --- linux-2.5.2-dj7/drivers/input/keyboard/amikbd.c	Wed Dec 31 16:00:00 1969
> +++ linux/drivers/input/keyboard/amikbd.c	Thu Jan 31 17:11:00 2002

> +static int __init amikbd_init(void)
> +{
> +	int i;
> +
> +	if (!AMIGAHW_PRESENT(AMI_KEYBOARD))
> +		return -EIO;

Please add

    if (!request_mem_region(CIAA_PHYSADDR-1+0xb00, 0x100, "amikeyb"))
            return -EBUSY;

here (cfr. drivers/char/amikeyb.c).

> +static void __exit amikbd_exit(void)
> +{
> +	input_unregister_device(&amikbd_dev);
> +	free_irq(IRQ_AMIGA_CIAA_SP, amikbd_interrupt);

And

    release_mem_region(CIAA_PHYSADDR-1+0xb00, 0x100);

here.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds