Re: [PATCH] Generic HDLC patch for 2.5.3

Jeff Garzik (garzik@havoc.gtf.org)
Sat, 2 Feb 2002 20:03:32 -0500


On Sun, Feb 03, 2002 at 12:46:28AM +0000, Alan Cox wrote:
> > It adds undiscussed networking changed which I very much doubt DaveM
> > would approve of, and I do not approve of: SIOCDEVICE is far too
> > generic for inclusion, and it adds a structure for passing untyped
> > data which is very definitely non-portable.
>
> You need a very generic structure for WAN interfaces because they have
> ridiculously large numbers of configurable options. These changes were
> discussed over a year ago.
>
> I agree with the comment about untyped data. That does want to be cleaned
> up a chunk more.

Ok... SIOC[GS]WANDEVICE or somesuch?

It could be made more portable and still say generic, IMHO.

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/