> > +static void __init init_8259A_devicefs(void)
> > +{
> > + device_register(&device_i8259A);
> > + strcpy(device_i8259A.name, "i8259A");
> > + strcpy(device_i8259A.bus_id, "0020");
> > + device_i8259A.parent = &sys_iobus;
>
> I'm not entirely familiar with the driverfs API but wouldn't an API
> function to do all that strcpy and other init assignments be a bit
> cleaner? I see lots of retyping going on otherwise, someone feel free to
> hit me with a clue bat if i'm missing something...
I guess that's okay. We do not helper with 1000 arguments to fill
structure up. It will be strcpy sometimes, sprintf
sometimes.... Better leave that alone.
Pavel
-- (about SSSCA) "I don't say this lightly. However, I really think that the U.S. no longer is classifiable as a democracy, but rather as a plutocracy." --hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/