Re: Fix for duplicate /proc entries

Tommy Reynolds (reynolds@redhat.com)
Fri, 8 Feb 2002 12:12:05 -0600


--=.n3B_4fkLQ1qtJp
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Uttered "Alexander Viro" <viro@math.psu.edu>, spoke thus:

> No point. Check that file already exist and BUG() if it does.
> Unconditionally. There's no need to be nice to broken code and yes,
> any code that tries to register existing procfs entry _is_ broken.
> That was never supposed to work.

Al, please confirm that your are asking Brent to reissue this patch with just
the checking and then BUG(). The current code fails but looks to the caller as
if it worked.

-- 
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- + -- -- -- -- -- -- -- -- -- --
Tommy Reynolds                               | mailto: <reynolds@redhat.com>
Red Hat, Inc., Embedded Development Services | Phone:  +1.256.704.9286
307 Wynn Drive NW, Huntsville, AL 35805 USA  | FAX:    +1.256.837.3839
Senior Software Developer                    | Mobile: +1.919.641.2923

--=.n3B_4fkLQ1qtJp Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux)

iEYEARECAAYFAjxkFPkACgkQWEn3bOOMcupagwCdFZq3dyitWrsnMVhH+MmUa7BY pAkAoJmH+HBrANq3LpJaXp24/VeBX6x2 =QKNV -----END PGP SIGNATURE-----

--=.n3B_4fkLQ1qtJp--

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/