Re: 2.5.5-dj2 compile failures

Martin Dalecki (dalecki@evision-ventures.com)
Wed, 27 Feb 2002 15:45:10 +0100

Just a sinde note
> - snd_pcm_lib_preallocate_isa_pages_for_all(pcm, 64*1024, chip->dma1 > 3 || chip->dma2 > 3 ? 128*1024 : 64*1024, GFP_KERNEL|GFP_DMA);
> + snd_pcm_lib_preallocate_isa_pages_for_all(pcm, 64*1024, chip->dma1 > 3 || chip->dma2 > 3 ? 128*1024 : 64*1024);

I think this method should be named as follows:

i_have_no_fear_of_wirst_desease_from_programming_linux_alsa_or_sound_drivers_at_all()

BAH! It should be: spl_alloc_isap() at most!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/