Re: [PATCH] spinlock not locked when unlocking in atm_dev_register

Robert Love (rml@tech9.net)
01 Mar 2002 17:35:08 -0500


On Fri, 2002-03-01 at 17:32, Maksim Krasnyanskiy wrote:

> > I don't have any knowledge of the source in question, but wouldn't a
> > possibility (perhaps even more likely) be that you should _add_ the
> > spin_lock instead of remove the spin_unlocks ?
>
> Absolutely correct :)
> I've got a patch for that, tested on SMP. I'll send it today or tomorrow.

Yah, I just looked at the code - again, I don't profess to know the atm
driver - but it seems to need the lock. Thanks.

> btw ATM locking seems to be messed up. Is anybody working on that ?

Not that I know of. Volunteer? :)

Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/