Re: OOPS: Multipath routing 2.4.17

kuznet@ms2.inr.ac.ru
Sat, 2 Mar 2002 15:59:49 +0300 (MSK)


Hello!

> w = jiffies % fi->fib_power;

power = fi->fib_power;
barrier();
if (power) ...

Such thing are made in this way.

> write_lock(&fib_info_lock);

DO NOT MAKE THIS! fib_info_lock must not be acquired in this context,
it will lockup. Just add a new lock, which is protected wrt softirqs.

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/