Re: [PATCH] IBM Lanstreamer bugfixes (round 3)

[Jeff Garzik]

David Dillow wrote:
> 
> Jeff Garzik wrote:
> > Set cache line size just like drivers/net/acenic.c does, and enable
> > memory-write-invalidate...
> 
> Does this mean the setup pci_enable_device() does on the cache line size
> is not sufficient?

pci_enable_device doesn't touch the PCI_COMMAND_INVALIDATE bit at all...

> I ask, because I've been relying on it for a driver I'm working on;
> should I be setting this as acenic does? It would seem that this is
> something many drivers would need to do...

Yes, acenic is the code to copy, for setting that up.

I need to create a pci_set_mwi() helper function.

	Jeff

-- 
Jeff Garzik      |
Building 1024    |
MandrakeSoft     | Choose life.