Re: [patch] 2.5 videodev redesign -- #3

[Oliver Neukum]

Am Montag, 4. März 2002 10:47 schrieb Gerd Knorr:
> > > Comments?  Bugs?  I plan to feed this to Linus soon ...
> >
> >  Hi,
> >
> >  it seems to me that you are not holding the BKL during
> >  the open method of the individual driver. This will
> >  cause races with unplugging on some USB cameras.
>
> What race exactly?

open() can race with videodev_unregister()

> I don't want videodev.c know details about the devices, it doesn't
> belong there.  If a usb cam needs locking, the usb cam's open() function
> should do that then.  I'll prefare fixing the usb drivers instead of
> calling driver->open() with BKL held.

Problematic. I found no other solution than the BKL.

	Regards
		Oliver