Re: [PATCH] serial.c procfs 2nd try - discussion

Russell King (rmk@arm.linux.org.uk)
Tue, 12 Mar 2002 09:11:44 +0000


On Mon, Mar 11, 2002 at 05:41:09PM -0800, Ed Vance wrote:
> 2. Does anybody know of anything that will break because of the leading
> zeros that are now present on the address field?

I'm not overly happy with this idea - there isn't anything that says an
ioport address has 4 digits. I know of machines where an ioport address
has 8, and I'm sure on the Alpha or Sparc64 its probably 16 digits.

It might be a better solution to leave the 'port:' element as-is if
programs like kudzu rely on that label there, and just fix the missing
statistics for iomem ports.

Then file a bug against kudzu and get them to fix that so it doesn't
SEGV when it finds something it doesn't like, and teach it about the
'mem' tag.

If kudzu ignores the serinfo: line as well, that's also another kudzu
bug.

Then fix the proc interface to report a 'mem' tag for each port.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/