> And IMO, we should have some basic validation of taskfile requests in
> the kernel...
> Reason 1: Standard kernel convention. In other ioctls, we check basic
> arguments and return EINVAL when they are wrong, even for privieleged
> ioctls.
If we assume that this path is for commands the kernel doesn't understand,
how do we validate them?
> Reason 2: If you have multiple programs issuing ATA commands, you would
> want a decent amount of synchronization, provided by the kernel, for the
> multiple user processes and multiple kernel processes issuing requests.
> Having the userspace commands come down a single spot in the kernel
> code makes this job a lot easier, if not making the impossible possible :)
Linus addressed this, I agree with his proposed three part implementation.
AFAIK he said the same thing in a different way.
-- bill davidsen <davidsen@tmr.com> CTO, TMR Associates, Inc Doing interesting things with little computers since 1979.- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/