Re: [PATCH] shift BKL out of notify_change
Richard Gooch (firstname.lastname@example.org)
Wed, 3 Apr 2002 16:58:01 -0700
Dave Hansen writes:
> My patch adds a semaphore to the inode structure, removes the BKL from
> notify_change(), and shifts the BKL into the individual filesystems'
> setattr() functions. I doubt that many of them actually need it, but I
> figure the FS maintainers can remove it. The BKL use in notify_change()
> is replaced by the semaphore i_attr_lock.
> diff -ur linux-2.5.7-clean/fs/devfs/base.c linux/fs/devfs/base.c
> --- linux-2.5.7-clean/fs/devfs/base.c Tue Apr 2 10:43:19 2002
> +++ linux/fs/devfs/base.c Wed Apr 3 13:49:11 2002
> @@ -2507,17 +2507,22 @@
> static int devfs_notify_change (struct dentry *dentry, struct iattr *iattr)
> - int retval;
> + int retval=0;
> struct devfs_entry *de;
> struct inode *inode = dentry->d_inode;
> - struct fs_info *fs_info = inode->i_sb->u.generic_sbp;
> + struct fs_info efs_info = inode->i_sb-nu.generic_sbp;
What on earth is this change? Some kind of cut-and-paste error?
> + lock_kernel();
The BKL isn't needed in this function, so please don't add it. I'd
just have to remove it again.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/