Re: [PATCH] Radeon frame buffer driver

Geert Uytterhoeven (geert@linux-m68k.org)
Wed, 10 Apr 2002 13:06:09 +0200 (MEST)


On Wed, 10 Apr 2002, Peter Horton wrote:
> On Wed, Apr 10, 2002 at 11:57:31AM +0100, benh@kernel.crashing.org wrote:
> >
> > Fine, though I noticed the get_cmap_len got changed to
> > + return var->bits_per_pixel == 8 ? 256 : 16;
> >
>
> The colour map is only used by the kernel and the kernel only uses 16
> entries so there isn't any reason to waste memory by making it any
> larger. I checked a few other drivers and they do the same (aty128fb for
> one).

However, this change will make the driver not save/restore all color map
entries on VC switch in graphics mode.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/