Re: [PATCH] fix ips driver compile problems

Alan Cox (alan@lxorguk.ukuu.org.uk)
Tue, 16 Apr 2002 20:12:10 +0100 (BST)


> Let's clarify. Is there a policy to get rid of drivers which don't
> conform, and if so are all the other drivers claimed to be compliant and
> this the only one which isn't? And if so, why hasn't someone just

They need fixing not removing. But right at the moment trying to fix drivers
is a fairly painful business since th block and scsi layers are still
somewhat in flux. Also for some drivers bringing them up to the 2.5
world is non trivial (eg I2O) and takes time anyway.

> Otherwise:
> - this makes the driver compile - good
> - this patch makes the driver WORK - also good

Bad.. - because now when you come to check you have them all fixed you'll
miss it out, and bad stuff might occur. You want it to choke unless the
user said "please dont choke on..." just so you can find them.

DaveJ's patch is much nicer

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/