Re: [PATCH] modularization of mem_init() for 2.4.19pre7

[Christoph Hellwig]

On Thu, Apr 18, 2002 at 11:17:22AM -0700, Patricia Gaughen wrote:
> -void __init mem_init(void)
> +void __init init_one_highpage(struct page *page, int pfn, int bad_ppro)
> +{
> +	if (!page_is_ram(pfn)) {
> +		SetPageReserved(page);
> +		return;
> +	}
> +	
> +	if (bad_ppro && page_kills_ppro(pfn))
> +	{
> +		SetPageReserved(page);
> +		return;
> +	}

I'd suggest to stay with one coding style.  Prefferedly that would be
the one in Documentation/CodingStyle.

> +
> +	reservedpages = 0;
> +	for (pfn = 0; pfn < max_low_pfn; pfn++)
> +		/*
> +		 * Only count reserved RAM pages
> +		 */
> +		if (page_is_ram(pfn) && PageReserved(mem_map+pfn))
> +			reservedpages++;

Adding braces around this hughe loop body would make it a little
more readable..

Besides these minor style nitpicks the pages look good to me.

BTW: Where is the NUMA code that builds ontop of this?

	Christoph