Re: 2.5.8: preemption + SMP broken ?

Robert Love (rml@tech9.net)
22 Apr 2002 14:16:30 -0400


On Sun, 2002-04-21 at 14:57, Pavel Machek wrote:

> Wel, if race is in migration code, you should fix migration, not add
> preempt_disable(), right? [Or is race preempt-onlly?]

I was not sure where the race was - I really did not see a preempt-only
race there, but I could not pinpoint the cause for an SMP race. Since
it was only showing itself as a preempt-related race, I disabled
preemption.

Erich Focht later pointed out that interrupts should be disabled in
migration_init and we sent a patch off to Linus. I will do some testing
and see if this fixes it (I suspect it may) and subsequently remove the
preempt code.

Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/