Re: [PATCH] 2.5.10 IDE 42

Martin Dalecki (dalecki@evision-ventures.com)
Fri, 26 Apr 2002 23:42:23 +0200


Uz.ytkownik Pavel Machek napisa?:

>>+ if (stat & READY_STAT)
>>+ printk("DriveReady ");
>>+ if (stat & WRERR_STAT)
>>+ printk("DeviceFault ");
>>+ if (stat & SEEK_STAT)
>>+ printk("SeekComplete ");
>>+ if (stat & DRQ_STAT)
>>+ printk("DataRequest ");
>>+ if (stat & ECC_STAT)
>>+ printk("CorrectedError ");
>>+ if (stat & INDEX_STAT)
>>+ printk("Index ");
>>+ if (stat & ERR_STAT)
>>+ printk("Error ");
>> }
>> printk("}");
>>-#endif /* FANCY_STATUS_DUMPS */
>>+#endif
>> printk("\n");
>> if ((stat & (BUSY_STAT|ERR_STAT)) == ERR_STAT) {
>> err = GET_ERR();
>
>
> I believe this is actually making it *less* readable.

It makes the waste of stack setup code and call instructions
more obvious then the former, so the chances are better that I will
come back and compactize the actually generated code a bit ;-)

BTW> Redundant comments can only be false. Like the following:

#ifdef DEFINE

#endif /* DEFINE */

/*
* some_function() is used for this and that
*/
some_function()
{
for (;;)
{
} /* for */
} /* some_function() */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/