Re: 2.5.12: hpt34x.c:259: too few arguments to function `ide_dmaproc'

[Martin Dalecki]

Uz.ytkownik Adrian Bunk napisa?:
> Just FYI:
> 
> The ide_dmaproc changes in 2.5.12 broke the compilation of hpt34x.c (I
> tried 2.5.12-dj1 but this shouldn't make a difference):
> 
> <--  snip  -->
> 
> ...
> gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.5/linux-2.5.12/include -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
> -mpreferred-stack-boundary=2 -march=k6   -nostdinc -I
> /usr/lib/gcc-lib/i386-linux/2.95.4
> /include -DKBUILD_BASENAME=hpt34x  -c -o hpt34x.o hpt34x.c
> hpt34x.c: In function `config_drive_xfer_rate':
> hpt34x.c:259: too few arguments to function `ide_dmaproc'
> hpt34x.c:281: too few arguments to function `ide_dmaproc'
> hpt34x.c:304: structure has no member named `dmaproc'
> hpt34x.c:305: warning: control reaches end of non-void function
> hpt34x.c: In function `hpt34x_dmaproc':
> hpt34x.c:350: too few arguments to function `ide_dmaproc'
> hpt34x.c: In function `ide_init_hpt34x':
> hpt34x.c:426: structure has no member named `dmaproc'
> make[3]: *** [hpt34x.o] Error 1
> make[3]: Leaving directory

Just adding a trailing struct request *rq parameter
to hpt34x_dmaproc() and passing it there to ide_dmaproc
as well as changing dmaproc to udma at line 426 will do.