Re: [PATCH] 2.5.12: remove VALID_PAGE

Linus Torvalds (torvalds@transmeta.com)
Thu, 2 May 2002 16:50:41 -0700 (PDT)


On Thu, 2 May 2002, Roman Zippel wrote:
>
> Ok, here is a new patch and it does indeed generate better code. :)
> virt_to_valid_page() also became virt_addr_valid().

You're going to hate me, but I'm going to ask you to do one more thing:
make "mk_pte_phys()" go away, and replace it with "pfn_pte(pfn,prot)".
Because logically it _is_ the reverse of "pte_pfn()", and that also means
that the HIGHMEM stuff on x86 would get cleaned up (we can generate
highmem pages without having a 64-bit physical address, we just have the
same old 32-bit PFN).

Pretty please?

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/