Re: [PATCH] double flush_page_to_ram

David S. Miller (davem@redhat.com)
Thu, 09 May 2002 04:56:43 -0700 (PDT)


From: Hugh Dickins <hugh@veritas.com>
Date: Thu, 9 May 2002 13:03:52 +0100 (BST)

filemap_nopage and shmem_nopage do flush_page_to_ram before returning
page, but do_no_page also does flush_page_to_ram on any page it slots
into the user address space. It's memory.c's business, remove it from
shmem and filemap (and cut outdated comment from when filemap copied).

Wrong, consider the case where we do early COW in do_no_page, you miss
a flush on the new-new page.

Please don't apply this patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/