Re: 2.5.15 laziness in export-objs

Patrick Mochel (mochel@osdl.org)
Fri, 10 May 2002 09:25:55 -0700 (PDT)


On Fri, 10 May 2002, Keith Owens wrote:

> 2.5.15 has four Makefiles where all objects are marked as exporting
> symbols. This is lazy coding and causes spurious rebuilds. Please
> specify only those objects that really export symbols.
>
> Also the export list is independent of whether an object is selected or
> not. That is, export-objs is unconditional.
>
> fs/nls/Makefile:export-objs = $(obj-y)
> arch/i386/pci/Makefile:export-objs += $(obj-y)
> drivers/base/Makefile:export-objs := $(obj-y)
> drivers/pci/Makefile:export-objs := $(obj-y)

Here is the patch for drivers/base.

-pat

===== drivers/base/Makefile 1.3 vs edited =====
--- 1.3/drivers/base/Makefile Tue Mar 26 14:26:45 2002
+++ edited/drivers/base/Makefile Fri May 10 09:24:33 2002
@@ -2,6 +2,6 @@

obj-y := core.o sys.o interface.o fs.o power.o

-export-objs := $(obj-y)
+export-objs := core.o fs.o power.o sys.o

include $(TOPDIR)/Rules.make

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/