Yep, needs fixing (there are still quite a lot of these in the tree)
> found a few other problems:
> 1) the pio fix posted last week is not included in your tree or Linus' and
Erm. That went into my tree a while back, and a day or so later, into
one of Martin's IDE-5x patches. It also went into Linus' tree a while
back. See changeset 1.513.1.14 at
> I found this the hard way: severe filesystem damage and system lockup and a
> kernel (2.4.19-pre8) panic because the root partition could not be mounted
> (as reported before).
Ah, 2.4.19 would be Marcelo's world.
> The following patch fixes this, apllies with an offset of -2 lines:
> -- begin patch --
> --- linux-2.5.10/drivers/ide/ide-taskfile.c Wed Apr 24 16:15:19 2002
> +++ linux/drivers/ide/ide-taskfile.c Fri Apr 26 15:44:42 2002
> @@ -202,7 +202,7 @@
> ata_write_slow(drive, buffer, wcount);
> - ata_write_16(drive, buffer, wcount<<1);
> + ata_write_16(drive, buffer, wcount);
Yes, it does look like a variant of this patch is missing there too.
Andre, Confirm? Line 112 looks suspect back there. Or is 2.4 doing
different voodoo with the wcount ?
> 2) After boot the system is not responsive to the keyboard, logging in via
> ssh and doing a `insmod psmouse` followed by a `rmmod psmouse` results in a
> working keyboard...
> before and after insmod there is no interrupt 1 listed in /proc/interrupts,
> but after doing the rmmod it is listed: " 1: 52 XT-PIC
> the mouse interrupt is listed as " 12: 154 XT-PIC i8042"
> the following message was issued after `rmmod psmouse`: "input: AT Set 2
> keyboard on isa0060/serio0"
Odd, That's one for Vojtech to think about 8-)
Thanks for the report.
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to email@example.com More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/