The disgust was targetted more at removing the abstraction of
locking scheme which I'd put in and having explicit lock_kernel() /
unlock_kernel() calls. I'd used (iirc) acquire_lock() / release_lock()
macros which could have just been redefined.
> The problem was that replacing the BKL with a semaphore
> seriously damaged Apache thoughput on 8-way. Apache
> was using flock()-based synchronisation and replacing
> a spin with a schedule just killed it.
Which says that our semaphores suck, because they don't try to spin for a
bit before scheduling. Of course, your change back was the right thing
to do in the 2.3.late timeframe.
-- Revolutions do not require corporate support. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to firstname.lastname@example.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/