Re: Strange s390 code in 2.4.19-pre8

[Martin Schwidefsky]

Hi Pete,
> I reviewed the -pre8 briefly, and is seems that the vast
> majority of s390/s390x changes are good, but I cannot discern
> the intent of some of them. I would like Martin or Ulrich
> to comment.
Ahh, its great that someone is doing reviews of our code.

> #1 - smp_call_function in a driver, trying to be ultra smart
> or IBM's hardware is too broken and asymmetric?
The iucv stuff in VM is a bit asymmetric ...

> #2 - strange changes to net Makefile
The intention of this is to have fsm.o built as a module if ctc
and iucv are built as modules too. I agree that this is broken
if one of {iucv,ctc} is built as a module and the other is built
in.

> #3 - config.in patch inconsistent or deadwood
> This is wonderful, but why did you merge it to Marcelo if the
> rest of the code is missing?
The rest is missing because we are waiting for the legal ok.
That the config.in contains these two lines is a mistake of mine.

> And, while we are on topic, when are you guys going to merge
> changes to the partitioning code?
I sent the patch together with the lcs driver to Marcelo last
week but I haven't heard of him yet. Wait and see ?

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: [e-mail]