Re: Strange s390 code in 2.4.19-pre8

Kai Germaschewski (kai@tp1.ruhr-uni-bochum.de)
Mon, 13 May 2002 11:30:06 -0500 (CDT)


On Mon, 13 May 2002, Pete Zaitcev wrote:

> Keith said to rename such things. Another easy thing to do
> would be to move EXPORT_SYMBOL into s390_ksyms.c, under
> #ifdef CONFIG_FSM_something. I understand that renaming
> creates a diff with 100% change, so damage can easily
> be slipped in, and then it's a hell to investigate.

No, putting the EXPORT_SYMBOL into s390_ksyms.c won't work for fsm.o being
a module. Renaming has the obvious disadvantage that the module name
changes as well.

I think I see two easy way to resolve the problem:
o backport the Rules.make change (it's been in 2.5 for months w/o even
anybody noticing it, so it's definitely stable)
o Move the EXPORT_SYMBOL() in drivers/isdn/hisax/fsm.o into
drivers/isdn/hisax/config.o

--Kai

> [Let's see if a well known persona uses it as an excuse
> for more commercial advertising of a certain software product].

;-)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/