Re: [PATCH] remove compat code for old devfs naming scheme

Richard Gooch (rgooch@ras.ucalgary.ca)
Tue, 14 May 2002 08:59:41 -0600


Christoph Hellwig writes:
> On Tue, May 14, 2002 at 08:35:03AM -0600, Richard Gooch wrote:
> > > As this was never present in official kernels there is really no need
> > > in keeping it - it just bloats the kernel.
> > >
> > > Could you please forward this patch to Linus and maybe Marcelo with
> > > your next devfs update?
> >
> > What on earth are you talking about? This code has been in the kernel
> > since 2.3.46. It's just lived in a different place: fs/devfs/util.c.
>
> Of course this code was present, otherwise it would be rather hard
> to remove it..
>
> But the old devfs naming scheme was obsolete before devfs was merged
> in 2.3.46 so there is no valid reason to support it for root=.

The reason to support it is because lots of people are depending on
it. A lot of systems would break for no real gain. This code is in the
init section, so the memory will be freed before init(8) starts.

The code should stay. In 2.5, I can move it into the mini devfsd that
will go into the initial rootfs.

Regards,

Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/