RE: [PATCH] 2.4.19-pre8 Fix for Intuos tablet in wacom.c

[Christer Nilsson]

Hi Frederic.

Can you take a look at this?

I've looked at the code at
http://people.mandrakesoft.com/~flepied/projects/wacom/ and found that
there's a couple of lines missing in the kernel driver. It seems that a
smoothing algorithm is left out
in the kernel source. My patch just circumvents that.

Christer Nilsson

> -----Original Message-----
> From: Greg KH [mailto:[e-mail]]
> Sent: Tuesday, May 14, 2002 5:38 PM
> To: Christer Nilsson; [e-mail]
> Cc: Linux-Kernel
> Subject: Re: [PATCH] 2.4.19-pre8 Fix for Intuos tablet in wacom.c
>
>
> On Tue, May 14, 2002 at 10:31:45AM +0200, Christer Nilsson wrote:
> >
> > The changes between 2.4.19-pre7 and 2.4.18-pre8 broke the Intuos part in
> > wacom.c
> > This will fix it.
> >
> > --- linux/drivers/usb/wacom.c.org	Tue May 14 00:40:12 2002
> > +++ linux/drivers/usb/wacom.c	Tue May 14 00:41:31 2002
> > @@ -288,8 +288,8 @@
> >  	x = ((__u32)data[2] << 8) | data[3];
> >  	y = ((__u32)data[4] << 8) | data[5];
> >
> > -	input_report_abs(dev, ABS_X, wacom->x);
> > -	input_report_abs(dev, ABS_Y, wacom->y);
> > +	input_report_abs(dev, ABS_X, wacom->x = x);
> > +	input_report_abs(dev, ABS_Y, wacom->y = y);
> >  	input_report_abs(dev, ABS_DISTANCE, data[9] >> 4);
> >
> >  	if ((data[1] & 0xb8) == 0xa0) {
> 	/* general pen packet */
> >
>
> Can you ask [e-mail] if this will break anything else, as that
> change was in his patch that is found at:
> 	http://people.mandrakesoft.com/~flepied/projects/wacom/
>
> thanks,
>
> greg k-h
>