Re: 2.4.19-pre8 non-kernel files in wan/8253x

Keith Owens (kaos@ocs.com.au)
Fri, 17 May 2002 08:29:34 +1000


On Thu, 16 May 2002 11:07:15 EDT,
TProvoni@aol.com wrote:
>In a message dated 5/16/2002 3:57:52 AM Eastern Daylight Time,
>kaos@ocs.com.au writes:
>> drivers/net/wan/8253x/Makefile contains these lines
>>
>> 8253xcfg: 8253xcfg.c
>> $(CC) -o 8253xcfg $(EXTRA_CFLAGS) -U__KERNEL__ 8253xcfg.c
>>
>> 8253xmac: 8253xmac.c
>> $(CC) -o 8253xmac $(EXTRA_CFLAGS) -U__KERNEL__ 8253xmac.c
>>
>> 8253xspeed: 8253xspeed.c
>> $(CC) -o 8253xspeed $(EXTRA_CFLAGS) -U__KERNEL__ 8253xspeed.c
>>
>> 8253xpeer: 8253xpeer.c
>> $(CC) -o 8253xpeer $(EXTRA_CFLAGS) -U__KERNEL__ 8253xpeer.c
>>
>> eprom9050: eprom9050.c
>> $(CC) -o eprom9050 $(EXTRA_CFLAGS) -U__KERNEL__ eprom9050.c
>>
>> All of those .c files are user space utilities, they do not fit the
>> kernel build system and do not belong in the kernel. Please move these
>> files to a separate user space package and delete from 2.4.19-pre*.
>
>I think there needs to be some way to guarantee that these last two programs
>are available whenever the driver is included with a kernel.

User space programs do not belong in the kernel. They belong in a user
space package, like all the other device tuning programs. The kernel
documentation for your driver points to the user space package.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/