Re: pci segments/domains

Jeff Garzik (jgarzik@mandrakesoft.com)
Fri, 17 May 2002 10:33:26 -0400


David S. Miller wrote:

> From: Jeff Garzik <jgarzik@mandrakesoft.com>
> Date: Fri, 17 May 2002 10:24:39 -0400
>
> I know -- that's what I mean by being more explicit. sysdata would
> become a pointer to struct pci_domain.
>
>No thanks, I want to say what the layout is for
>this object. What pci_domain will end up doing is
>making for one more dereference to "arch private"
>state and that stinks for performance :-)
>

See my previous message from the other day... this would be defined in
each arch's asm/pci.h, which eliminates this problem you describe. Each
arch maintainer would indeed decide how to define it, though over time
I'm sure it would grow commonly-named struct members.

My main want is cosmetic -- call a spade a spade, so to speak.
s/sysdata/pci_domain/ But doing so opens the door to increased
flexibility. Later steps can add common members needed by pci-to-pci
IOMMU tricks which are common to most platforms.

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/