Re: [PATCH] Possible EXT2 File System Corruption in Kernel 2.4

Juan Quintela (quintela@mandrakesoft.com)
20 May 2002 11:38:52 +0200


>>>>> "andreas" == Andreas Dilger <adilger@clusterfs.com> writes:

Hi

Sorry for reading so late that mail.

andreas> diff -ru linux-2.4.18.orig/fs/ext2/balloc.c linux-2.4.18-aed/fs/ext2/balloc.c
andreas> --- linux-2.4.18.orig/fs/ext2/balloc.c Wed Feb 27 10:31:58 2002
andreas> +++ linux-2.4.18-aed/fs/ext2/balloc.c Mon Mar 18 17:07:55 2002
andreas> @@ -269,7 +269,8 @@
andreas> }
andreas> lock_super (sb);
andreas> es = sb->u.ext2_sb.s_es;
andreas> - if (block < le32_to_cpu(es->s_first_data_block) ||
andreas> + if (block < le32_to_cpu(es->s_first_data_block) ||
andreas> + block + count < block ||

It is just me, or this will allways be false? A fast grep shows that
count is always bigger than 1. Same for the ext3 part.

Later, Juan.

-- 
In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/