Re: Initialisation bug in IDE patch

Andrew Pam (xanni@glasswings.com.au)
Wed, 22 May 2002 15:55:15 +1000


On Wed, May 22, 2002 at 03:15:10PM +1000, Andrew Pam wrote:
> In the latest available kernel 2.2 IDE patch "ide-2.2.20.01102002.patch"
> there is a bug that prevents ide_setup in drivers/block/ide.c
> from accepting kernel parameters selecting special IDE hardware.
>
> The ide_init_default_hwifs() function in include/asm-*/ide.h fails to
> initialise the "hw_regs_t hw" variable, thus leaving uninitialised data
> in some fields. Specifically, the "chipset" field is uninitialised which
> causes the "if (hwif->chipset != ide_unknown)" test in drivers/block/ide.c
> to always fail with the error message " -- BAD OPTION".

This bug also appears to be present in the mainline 2.4 kernel IDE code.
I haven't checked the 2.5 code yet.

Regards,
Andrew Pam

-- 
mailto:xanni@xanadu.net                         Andrew Pam
http://www.xanadu.com.au/                       Chief Scientist, Xanadu
http://www.glasswings.com.au/                   Technology Manager, Glass Wings
http://www.sericyb.com.au/                      Manager, Serious Cybernetics
http://two-cents-worth.com/?105347&EG		Donate two cents to our work!
P.O. Box 477, Blackburn VIC 3130 Australia	Phone +61 401 258 915
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/