Re: [PATCH] XBUG(comment) BUG enhancement

Benjamin LaHaise (bcrl@redhat.com)
Fri, 24 May 2002 02:49:06 -0400


On Fri, May 24, 2002 at 03:24:30PM +1000, Rusty Russell wrote:
> __asm__ __volatile__( "ud2\n" \
> - "\t.word %c0\n" \
> + "\t.long %c0\n" \
> "\t.long %c1\n" \
> - : : "i" (__LINE__), "i" (__FILE__))
> + : : "i" (__stringify(__LINE__)), "i" (__FILE__))

This part I can't agree with: changing the line number to a string
results in excess pollution of the data segment with useless strings
that are frequently duplicates. Why not leave it as a number?

-ben
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/