Re: [RFC][PATCH] using page aging to shrink caches (pre8-ac5)

Ed Tomlinson (tomlins@cam.org)
Fri, 24 May 2002 08:14:25 -0400


On May 24, 2002 07:35 am, Christoph Hellwig wrote:
> On Fri, May 24, 2002 at 07:28:45AM -0400, Ed Tomlinson wrote:
> > Comments, questions and feedback very welcome,
>
> Just from a short look:
>
> What about doing mark_page_accessed in kmem_touch_page?

mark_page_accessed expects a page struct. kmem_touch_page takes an
address in the page, converts it to a kernel address and then marks the page.

> And please do a s/pruner_t/kmem_pruner_t/

Yes. Done.

One other style question. I am not completely happy with kmem_shrink_slab.
Think that instead of setting the reference bit I should probably do something
like return:

-1 - cache is growing
0 - slab has inuse objects
n - pages were freed

Comments?
Ed Tomlinson

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/