Re: [PATCH,CFT] Tentative fix for mem. corruption caused by intel

Nicolas Aspert (Nicolas.Aspert@epfl.ch)
Mon, 27 May 2002 12:09:05 +0200


Alan Cox wrote:
> On Mon, 2002-05-27 at 10:32, Nicolas Aspert wrote:
> p to */
>
>>+ pci_read_config_dword(agp_bridge.dev, INTEL_APBASE, &temp);
>>+ agp_bridge.gart_bus_addr = (temp & PCI_BASE_ADDRESS_MEM_MASK);
>>+
>>+ /* attbase - aperture base */
>>+ /* the Intel 815 chipset spec. says that bits 29-31 in the
>>+ * ATTBASE register are reserved -> try not to write them */
>>+ if (agp_bridge.gatt_bus_addr & (~ INTEL_815_ATTBASE_MASK))
>>+ panic("gatt bus addr too high");
>>+ addr = agp_bridge.gatt_bus_addr & INTEL_815_ATTBASE_MASK;
>
>
> You need to add + temp&~INTEL_815_ATTBASE_MASK ..
>
>

I am not sure to understand... Do you really mean mixing 'APBASE' which
is the AGP base aperture adress along with the *gatt* which is the
translation table adress ? If yes, I think I need a supplementary
explanation...

Best regards.

-- 
Nicolas Aspert      Signal Processing Institute (ITS)
Swiss Federal Institute of Technology (EPFL)

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/