Re: [PATCH] 2.5.18 IDE 73

Gerald Champagne (gerald@io.com)
29 May 2002 08:59:44 -0500


>- ide_driveid_update is gone. We don't report the drive id through
> /proc/ide and we don't have to update it any longer on the fly. Still
> someone out there complaining that it went away!?

But the id information is still available through the ioctl interface.
ide_driveid_update was used to update the dma_ultra, dma_mword, and
dma_lword fields in the id structure after changing the rate with an
ioctl command. Won't these fields be wrong if the rate is changed after
initialization? Won't "hdparm -i" show outdated and incorrect
information.

It's good to see the duplicate identify routine go away, but the ioctl
shouldn't return incorrect information. Can the remaining identify
routine be modified and called directly from the ioctl that returns the
id information?

Gerald

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/