Re: 2.5.20 RAID5 compile error

Jens Axboe (axboe@suse.de)
Tue, 4 Jun 2002 14:21:05 +0200


On Tue, Jun 04 2002, Neil Brown wrote:
> On Tuesday June 4, axboe@suse.de wrote:
> >
> > What changes did you have in mind?
>
> http://www.cse.unsw.edu.au/~neilb/patches/linux-devel/2.5.20/patch-A-NewPlug
>
> Is what I had against 2.5.20. A quick look at the mail that you sent
> with improvements suggest that I can be even less intrusive.. But it
> will have to wait until tomorrow (my time).

Ah ok, I see what you have in mind. Right now you are completely
mimicking the tq_struct setup -- any reason a simple q->plug_fn is not
enough? Do you ever need anything else than the queue passed in with the
plug? Wrt umem, it seems you could keep 'card' in the queuedata. Same
for raid5 and conf.

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/