Re: [PATCH] Trivial, IDE geometry fix / defconfig changes

Guest section DW (dwguest@win.tue.nl)
Wed, 5 Jun 2002 01:41:46 +0200


On Tue, Jun 04, 2002 at 09:56:17PM +0100, Robert Cardell wrote:

> --- ide-disk.c.old Tue Jun 4 21:09:10 2002
> +++ ide-disk.c Tue Jun 4 21:09:44 2002
> @@ -929,9 +929,9 @@
>
> if (id->cfs_enable_2 & 0x0400) {
> capacity_2 = id->lba_capacity_2;
> - drive->cyl = (unsigned int) capacity_2 / (drive->head * drive->sect);
> drive->head = drive->bios_head = 255;
> drive->sect = drive->bios_sect = 63;
> + drive->cyl = (unsigned int) capacity_2 / (drive->head * drive->sect);
> drive->select.b.lba = 1;
> set_max_ext = idedisk_read_native_max_address_ext(drive);
> if (set_max_ext > capacity_2) {
>

Yes, let me confirm: this patch is required.
I sent it to the list on 10 Feb 2002 ("[PATCH] tiny IDE fixes"); apparently
nobody picked it up, or at least it didnt reach 2.4.19-pre9 yet.
That patch also removed some dead code.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/