Re: [PATCH] remove suser()

Ruth Ivimey-Cook (Ruth.Ivimey-Cook@ivimey.org)
Thu, 6 Jun 2002 23:32:33 +0100 (BST)


On Thu, 6 Jun 2002, Pavel Machek wrote:

>> diff -urN linux-2.5.20/include/linux/compatmac.h linux/include/linux/compatmac.h
>> --- linux-2.5.20/include/linux/compatmac.h Sun Jun 2 18:44:41 2002
>> +++ linux/include/linux/compatmac.h Tue Jun 4 13:57:33 2002
>> @@ -102,8 +102,6 @@
>>
>> #define my_iounmap(x, b) (((long)x<0x100000)?0:vfree ((void*)x))
>>
>> -#define capable(x) suser()
>> -
>> #define tty_flip_buffer_push(tty) queue_task(&tty->flip.tqueue, &tq_timer)
>
>This is not right I believe. You want to keep compatibility for older
>kernels.
>
> Pavel

Why? The file being changed is in a particular kernel, not in, say, glibc; to
require compatibilty btw. a file in kernel X and another in kernel Y seems
stupid... but perhaps I misunderstand.

Ruth

-- 
Ruth Ivimey-Cook
Software engineer and technical writer.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/