Re: remove magic numbers for fault return codes

William Lee Irwin III (wli@holomorphy.com)
Fri, 7 Jun 2002 16:58:00 -0700


On Fri, Jun 07, 2002 at 04:52:59PM -0700, William Lee Irwin III wrote:
> This patch removes them in favor of defining integer constants with
> mnemonic names and using them as the return codes and in dispatches
> on the return values from handle_mm_fault(), and also removing some of
> the associated comments explaining what the magic numbers mean at
> various points where they were formerly used. In addition two redundant
> variables were removed, a comment was added to the bad_wp_page: label
> to explain to onlookers more of what the printk() there means, and
> failure to match the return code with a value in the various switch()
> statements on the return code was flagged as a BUG() at various points.

This is against 2.5.20, sorry for not mentioning that before.

Cheers,
Bill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/