Re: isdn oops with 2.4.19-pre10

Kai Germaschewski (kai@tp1.ruhr-uni-bochum.de)
Mon, 17 Jun 2002 11:02:44 -0500 (CDT)


On Mon, 17 Jun 2002, Kristian Peters wrote:

> I'm connecting with the avmb1-card to a provider via pppd and starting
> my iptables firewall (with qos scheduling). While connected or after
> shutting down the connection unloading the hisax or isdn modules
> produces that oops. I haven't tried it without the sched-modules loaded.
> Should I ? It seems that they could be responsible too.

Actually that's the case I was thinking of. capidrv gets loaded last, but
is not removed first.

Could you try if the appended patch fixes it?

--Kai

===== drivers/isdn/isdn_common.c 1.15 vs edited =====
--- 1.15/drivers/isdn/isdn_common.c Tue Feb 5 08:07:05 2002
+++ edited/drivers/isdn/isdn_common.c Mon Jun 17 10:57:11 2002
@@ -75,9 +75,11 @@
isdn_lock_drivers(void)
{
int i;
+ isdn_ctrl cmd;

- for (i = 0; i < dev->drivers; i++) {
- isdn_ctrl cmd;
+ for (i = 0; i < ISDN_MAX_DRIVERS; i++) {
+ if (!dev->drv[i])
+ continue;

cmd.driver = i;
cmd.arg = 0;
@@ -99,7 +101,10 @@
{
int i;

- for (i = 0; i < dev->drivers; i++)
+ for (i = 0; i < ISDN_MAX_DRIVERS; i++) {
+ if (!dev->drv[i])
+ continue;
+
if (dev->drv[i]->locks > 0) {
isdn_ctrl cmd;

@@ -109,6 +114,7 @@
isdn_command(&cmd);
dev->drv[i]->locks--;
}
+ }
}

void

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/