Re: 2.5.x: arch/i386/kernel/cpu

Dave Jones (davej@suse.de)
Wed, 19 Jun 2002 06:38:07 +0200


On Tue, Jun 18, 2002 at 08:45:18PM -0700, H. Peter Anvin wrote:
> Whomever broke up arch/i386/kernel/setup.c and created the CPU
> directory (very good idea) messed up in at least one place:

Patrick Mochel takes credit/glory/fame/blame for this one.

> The *AMD-defined* CPUID flags (0x80000001) are not just used on AMD
> processors! In fact, at least AMD, Transmeta, Cyrix and VIA all use
> them; I don't know about Centaur or Rise. Intel supports the actual
> level starting with the P4 although it returns all zero.

Bugger, you're right.

On my Cyrix III box before..

CPU: After vendor init, caps: 00803135 80803035 00000000 00000000
CPU: After generic, caps: 00803135 80803035 00000000 00000000
CPU: Common caps: 00803135 80803035 00000000 00000000

and after..

CPU: After vendor init, caps: 00803135 80000000 00000000 00000000
CPU: After generic, caps: 00803135 80000000 00000000 00000000
CPU: Common caps: 00803135 80000000 00000000 00000000

Interesting how it's picking up that 8 in the 2nd set of caps, but
not any of the other bits..

> It should, in my opinion, be moved into generic_identify(). Anyone
> who has a reason why that shouldn't be done speak now or I'll send the
> patch to Linus.

Sounds reasonable to me, unless Patrick has a preferred way of fixing
this problem.

Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/