Re: Linux 2.5.23-dj2

[Adrian Bunk]

On Wed, 19 Jun 2002, Dave Jones wrote:

> Lots of bits got thrown out this time, as Christoph Hellwig went through
> the patch and picked up on quite a few obviously wrong bits. In addition,
>...

Another obviously wrong bit seems to be the patch below that is still in
-dj2:

- it adds a function that isn't used in neither plain 2.5.23 nor by
  anything in the -dj2 patch
- it doesn't compile

cu
Adrian

--- linux-2.5.23/drivers/isdn/hardware/avm/b1.c	Wed Jun 19 03:11:52 2002
+++ linux-2.5/drivers/isdn/hardware/avm/b1.c	Sat Jun  1 00:34:35 2002
@@ -59,6 +59,21 @@

 /* ------------------------------------------------------------- */

+void b1_set_revision(struct capi_driver *driver, char *rev)
+{
+	char *p;
+
+	if ((p = strchr(rev, ':')) != 0 && p[1]) {
+		strncpy(driver->revision, p + 2, sizeof(driver->revision));
+		driver->revision[sizeof(driver->revision)-1] = 0;
+		if ((p = strchr(driver->revision, '$')) != 0 && p > driver->revision)
+			*(p-1) = 0;
+	}
+	printk(KERN_INFO "%s: revision %s\n", driver->name, driver->revision);
+}
+
+/* ------------------------------------------------------------- */
+
 avmcard *b1_alloc_card(int nr_controllers)
 {
 	avmcard *card;