Re: IDE booting problems with 2.5.23

Jens Axboe (axboe@suse.de)
Thu, 20 Jun 2002 12:35:32 +0200


On Thu, Jun 20 2002, Martin Dalecki wrote:
> BTW> Jens did you notice that the IDE_DMA flag is a "read only"
> flag? I see basically only TQC code checking it. I would
> like to replace the drive->waiting_for_dma flag field by the
> proper usage of the IDE_DMA bit. Any way this could bite TCQ code?
> The checks there appear to be only sanity checks anyway.

At first I did just add them as sanity checks, but later on I had the
same thought myself (get rid of drive->waiting_for_dma). So go ahead
with that.

BTW, I see you renamed the flags to channel->active. I think that's a
bit misleading, can't you just call it ->state or ->flags (or
->state_flags? :-)

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/