Re: Optimisation for smp_num_cpus loop in hotplug

Pete Zaitcev (zaitcev@redhat.com)
Fri, 21 Jun 2002 00:16:18 -0400


> for (i = 0; i < NR_CPUS; i++) {
> if (!cpu_online(i))
> continue;
>
> Since the cpu online map is probably going to be quite sparse,
> could I suggest this alternative, which doesn't have to loop 32 times:

> +#define for_each_cpu(cpu, mask) \
> + for(mask = cpu_online_map; \
> + cpu = __ffs(mask), mask != 0; \
> + mask &= ~(1<<cpu))
> +

This is neat, but I'd like to see it work with O(1) as well.
Mingo's code uses some long bitmaps.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/