[PATCH]: { 2.5 } Correcting comment in include/asm-i386/tlbflush.h

Manik Raina (manik@cisco.com)
Mon, 01 Jul 2002 17:02:50 +0530


This is a multi-part message in MIME format.
--------------9BEEC8E7222BA1EF87736D92
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

TLB flush happens when the CR3 register is written to. Comment is
misleading ....

--------------9BEEC8E7222BA1EF87736D92
Content-Type: text/plain; charset=us-ascii;
name="tlb.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="tlb.diff"

diff -u -U 6 -r linux-2.5.24/include/asm-i386/tlbflush.h nice/include/asm-i386/tlbflush.h
--- linux-2.5.24/include/asm-i386/tlbflush.h Fri Jun 21 04:23:51 2002
+++ nice/include/asm-i386/tlbflush.h Mon Jul 1 16:54:31 2002
@@ -7,14 +7,14 @@

#define __flush_tlb() \
do { \
unsigned int tmpreg; \
\
__asm__ __volatile__( \
- "movl %%cr3, %0; # flush TLB \n" \
- "movl %0, %%cr3; \n" \
+ "movl %%cr3, %0; \n" \
+ "movl %0, %%cr3; # flush TLB \n" \
: "=r" (tmpreg) \
:: "memory"); \
} while (0)

/*
* Global pages have to be flushed a bit differently. Not a real
@@ -23,14 +23,14 @@
#define __flush_tlb_global() \
do { \
unsigned int tmpreg; \
\
__asm__ __volatile__( \
"movl %1, %%cr4; # turn off PGE \n" \
- "movl %%cr3, %0; # flush TLB \n" \
- "movl %0, %%cr3; \n" \
+ "movl %%cr3, %0; \n" \
+ "movl %0, %%cr3; # flush TLB \n" \
"movl %2, %%cr4; # turn PGE back on \n" \
: "=&r" (tmpreg) \
: "r" (mmu_cr4_features & ~X86_CR4_PGE), \
"r" (mmu_cr4_features) \
: "memory"); \
} while (0)

--------------9BEEC8E7222BA1EF87736D92--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/