Re: lock_kernel check...

[Zwane Mwaikambo]

On Tue, 9 Jul 2002, Dave Hansen wrote:

> It isn't absoulutely a bad thing to return while you have a lock held. 
>     It might be hard to understand, or even crazy, but not immediately 
> wrong :)
> 
> // BKL protects both "a", and io port 0xF00D
> bar()
> {
> 	lock_kernel();
> 	return inb(0xF00D);
> }
> 
> int a;
> foo()
> {
> 	a = bar();
> 	a--;
> 	unlock_kernel();
> }

But broken nonetheless, that kinda thing just looks ugly. Especially when 
someone tries to call bar multiple times or consecutively or with the lock 
already held or...

	Zwane Mwaikambo

-- 
function.linuxpower.ca