[PATCH] AFFS fix return without releasing BKL

Dave Hansen (haveblue@us.ibm.com)
Thu, 11 Jul 2002 00:28:15 -0700

This is a multi-part message in MIME format.
--------------040005020801000203020607
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Linus,
This was found by Dan Carpenter <error27@email.com>, using an smatch
script. Looks to me like like an error caused during all the BKL
pushing. 1 more coming...

Not tested (Greg, please don't hurt me :p )

-- 
Dave Hansen
haveblue@us.ibm.com


--------------040005020801000203020607
Content-Type: text/plain;
 name="affs-bkl_ret-2.5.25-0.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="affs-bkl_ret-2.5.25-0.patch"


--- linux-2.5.25-clean/fs/affs/namei.c	Thu Jun 20 15:53:49 2002
+++ linux/fs/affs/namei.c	Thu Jul 11 00:15:16 2002
@@ -345,8 +345,10 @@
 	lock_kernel();
 
 	/* WTF??? */
-	if (!dentry->d_inode)
+	if (!dentry->d_inode) {
+		unlock_kernel();
 		return -ENOENT;
+	}
 
 	res = affs_remove_header(dentry);
 	unlock_kernel();


--------------040005020801000203020607--


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/