Re: close return value

Alan Cox (alan@lxorguk.ukuu.org.uk)
17 Jul 2002 02:35:41 +0100


On Wed, 2002-07-17 at 00:52, David S. Miller wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: 17 Jul 2002 02:03:02 +0100
>
> close() checking is not about physical disk guarantees. It's about more
> basic "I/O completed". In some future Linux only close() might tell you
> about some kinds of I/O error. The fact it doesn't do it now is no
> excuse for sloppy programming
>
> Practice dictates that if you make close() return error values
> your whole system will blow up. Try it out for yourself.
> I can tell you of at least 1 app that is going to explode :-)
>
> I believe Linus mentioned way back when that this is a "shall not"
> when we had similar problems with NFS returning errors from close().

Our NFS can return errors from close(). So I'd get fixing the
applications.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/