Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update (looks strange)

[Francois Romieu]

Greetings,

support <[e-mail]> :
[...]
>     Now we are the maintainer of pdc202xx controllers. We know the
> ASIC detail spec. So please let us modify and maintain.
> We can provide best support for world wide Promise users.

+#define set_2regs(a, b) \
+        OUT_BYTE((a + adj), indexreg); \
+       OUT_BYTE(b, datareg);
+
+#define set_reg_and_wait(value, reg, delay) \
+       OUT_BYTE(value, reg); \
+        mdelay(delay);

Hmmm...

[...]
+       if (speed == XFER_UDMA_2)
+               set_2regs(thold, (IN_BYTE(datareg) & 0x7f));

Oops

[...]
+       if (new_chip) {
+               if (id->capability & 4) /* IORDY_EN & PREFETCH_EN */
+                       set_2regs(iordy, (IN_BYTE(datareg) | 0x03));
+       }

Oops

-- 
Ueimor